Fix PHP Warning: Module 'newrelic' already loaded in Unknown on line 0 (Debian) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any progress on this? I would like to see it resolved. thanks |
|
Apologies for the delay in reviewing this - I've been away for a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Debian systems, the .deb package installs:
Additionally, this module calls newrelic-install, that places:
At this point there're two files per PHP SAPI declaring
extension=newrelic.soSo the module tries tu purge the offending files with the purge_files artifact - https://github.com/claranet/puppet-newrelic/blob/master/manifests/agent/php.pp#L18
The params value for $purge_files are missing the cli sapi, so the problem is not fixed in full. Moreover, Debian stretch and the various php versions provided by https://deb.sury.org/ allows several php versions to coexist. At the end we want to remove all those files
/etc/php/{5.6,7.0,7.1,7.2}/{apache2,cli,fpm}/conf.d/newrelic.ini.Let's go a step back. The debian packages already put the files in place. It's not needed to run newrelic-install. This PR removes the $purge_files thing and disables the execution of newrelic-install in debian.